Attention is currently required from: arehbein, daniel, fixeria.

View Change

2 comments:

• File src/osmo-bsc/meas_feed.c:

  • Patch Set #6, Line 33: static struct meas_feed_state g_mfs = {.txqueue_max = MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT};

    I kind of like using a different style for structs as opposed to the style used for function definit […]

    I gree with Daniel, we usually use the way he proposed.
    For sure at least you should leave some space before/after "{ }"

  • Patch Set #6, Line 133: struct osmo_io_ops meas_feed_oio = {.read_cb = NULL, .write_cb = meas_feed_noop_cb,

    Here as well

    Ack

To view, visit change 34526. To unsubscribe, or for help writing mail filters, visit settings.