Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32206 ) Change subject: msc_mgw_setup: use mgcp_client_pool_empty() ...................................................................... Patch Set 2: (1 comment) File src/osmo-msc/msc_main.c: https://gerrit.osmocom.org/c/osmo-msc/+/32206/comment/bf7bdf94_ca8bbdcb PS2, Line 565: if (pool_members_initalized) { Can you perhaps now change this to have the error as early termination? it's way clearer imho since there starts to be several branches: ``` if (!pool_members_initalized) { LOGP(DMSC, LOGL_ERROR, "MGW pool failed to configure any pool members\n"); return -EINVAL; } LOGP(DMSC, LOGL_NOTICE, "MGW pool with %u pool members configured, (ignoring MGW configuration in VTY node 'msc').\n", pool_members_initalized); return 0; ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I44e7b2723d801ceb03aaa2e5546802b4eb56b3c3 Gerrit-Change-Number: 32206 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Apr 2023 13:57:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment