Attention is currently required from: osmith.

View Change

1 comment:

• File src/osmo-msc/msc_main.c:

  • Patch Set #2, Line 565: if (pool_members_initalized) {

    Can you perhaps now change this to have the error as early termination? it's way clearer imho since there starts to be several branches:

    ```
     if (!pool_members_initalized) {
       LOGP(DMSC, LOGL_ERROR, "MGW pool failed to configure any pool members\n");
       return -EINVAL;
     }
     
      LOGP(DMSC, LOGL_NOTICE,
           "MGW pool with %u pool members configured, (ignoring MGW configuration in VTY node 'msc').\n",
           pool_members_initalized);
     return 0;
     
    ```

To view, visit change 32206. To unsubscribe, or for help writing mail filters, visit settings.