Attention is currently required from: neels, pespin, dexter.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33216 )

Change subject: osmo_sccp_simple_client_on_ss7_id(): Support ASP explicitly configured as sctp server ......................................................................

Patch Set 8:

(2 comments)

File src/osmo_ss7_vty.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/33216/comment/01d59d37_c2ff2e0d PS8, Line 858: || !asp->cfg.is_server I wonder if this still makes sense. Is there any way asp->cfg.is_server could be set to true without going through the VTY?

File src/sccp_user.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/33216/comment/10792355_d13c5093 PS8, Line 648: asp->cfg.is_server = false; should we print a warning here? again not sure if asp->cfg.is_server can change without the vty