Attention is currently required from: neels, pespin, dexter.
View Change
2 comments:
File src/osmo_ss7_vty.c:
Patch Set #8, Line 858: || !asp->cfg.is_server
I wonder if this still makes sense. Is there any way asp->cfg.is_server could be set to true without going through the VTY?
File src/sccp_user.c:
Patch Set #8, Line 648: asp->cfg.is_server = false;
should we print a warning here? again not sure if asp->cfg.is_server can change without the vty
To view, visit change 33216. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I20de33edb8751a515d6719c49efadfc387dd85f8
Gerrit-Change-Number: 33216
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jun 2023 11:49:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment