Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28176 )

Change subject: coding: add gsm0503_detect_a[fh]s_dtx_frame2() ......................................................................

Patch Set 2:

(1 comment)

File src/coding/gsm0503_amr_dtx.c:

https://gerrit.osmocom.org/c/libosmocore/+/28176/comment/41180d83_05cc3dd9 PS2, Line 109: if (*sbits == 0 || id_marker[k] != S2U(*sbits))

I see everywhere you use S2U you also check agianst *sbits==0. […]

No, it does not because 0 is a special value indicating uncertainty between 1 and 0. If we go for '<=', then soft-bit 0 would be equal to -127 or hard-bit 1. Other code parts in libosmocoding also treat soft-bit 0 as an error, so I am doing the same here.