Attention is currently required from: pespin.
1 comment:
File src/coding/gsm0503_amr_dtx.c:
Patch Set #2, Line 109: if (*sbits == 0 || id_marker[k] != S2U(*sbits))
I see everywhere you use S2U you also check agianst *sbits==0. […]
No, it does not because 0 is a special value indicating uncertainty between 1 and 0. If we go for '<=', then soft-bit 0 would be equal to -127 or hard-bit 1. Other code parts in libosmocoding also treat soft-bit 0 as an error, so I am doing the same here.
To view, visit change 28176. To unsubscribe, or for help writing mail filters, visit settings.