Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28244 ) Change subject: add pfcp_endpoint ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File include/osmocom/pfcp/pfcp_endpoint.h: https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/2e3eb482_139e229b PS3, Line 104: We used a lot of public structs in the beginning, and my experience is that this _usually_ haunts us if there are changes happening again and again. Breaking the ABI should be avoided if possible. "Simple recompilation" is the perspective of a developer, not of a user, who may want to run old binaries with new libraries and vice-versa for testing. Also, think of people wanting to use significantly different versions of osmo-* programs with one system-wide install of libosmo-foo. Basically it comes down to: Do we as developers want to shift burden/cosntraints to distributions or users, or do we invest more effort on our end to make their life easier. I always hold projects with full getter/setter API in the highsest regard, as it shows the developers went the extra mile. One can see this "more evolved" development culture e.g. in code that Pablo wrote (libosmo-netif, libgtpnl, ...). Having said all of the above, we don't have a clear policy on it in osmocom. I just wanted to share my thoughts on the matter. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac Gerrit-Change-Number: 28244 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Jun 2022 09:12:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment