Attention is currently required from: neels, pespin.
Patch set 4:Code-Review +1
1 comment:
File include/osmocom/pfcp/pfcp_endpoint.h:
every time i have written API with opaque structs, i have regretted it from the extensive work requi […]
We used a lot of public structs in the beginning, and my experience is that this _usually_ haunts us if there are changes happening again and again. Breaking the ABI should be avoided if possible. "Simple recompilation" is the perspective of a developer, not of a user, who may want to run old binaries with new libraries and vice-versa for testing. Also, think of people wanting to use significantly different versions of osmo-* programs with one system-wide install of libosmo-foo.
Basically it comes down to: Do we as developers want to shift burden/cosntraints to distributions or users, or do we invest more effort on our end to make their life easier. I always hold projects with full getter/setter API in the highsest regard, as it shows the developers went the extra mile. One can see this "more evolved" development culture e.g. in code that Pablo wrote (libosmo-netif, libgtpnl, ...).
Having said all of the above, we don't have a clear policy on it in osmocom. I just wanted to share my thoughts on the matter.
To view, visit change 28244. To unsubscribe, or for help writing mail filters, visit settings.