Attention is currently required from: dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/28169
)
Change subject: pySim-shell: match SW in apdu command
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/28169/comment/6e3f8559_23824a41
PS1, Line 249: expect_sw
I would avoid mixing '-' and '_' in command options, '--expect-sw'
looks more natural to me.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/28169
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic5a52d7cf533c51d111850eb6d8147011a48ae6c
Gerrit-Change-Number: 28169
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 May 2022 20:06:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment