Attention is currently required from: dexter.
Patch set 1:Code-Review -1
View Change
1 comment:
File pySim-shell.py:
Patch Set #1, Line 249: expect_sw
I would avoid mixing '-' and '_' in command options, '--expect-sw' looks more natural to me.
To view, visit change 28169. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic5a52d7cf533c51d111850eb6d8147011a48ae6c
Gerrit-Change-Number: 28169
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Thu, 26 May 2022 20:06:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment