Attention is currently required from: Hoernchen, lynxis lazus, pespin.

laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42171?usp=email )

Change subject: dfu: irq: replace if(states) with a switch case ......................................................................

Patch Set 4: Code-Review+2

(1 comment)

Patchset:

PS2:

This pointlessly churns code to muddy the blame without improving anything..

Nobody is blaming anyone for the way how the code it, at least not that I have seen/heard about it. I think the switch statement is a readability improvement - but it's of course what I'd call "sideways development" as it doesn't really appear to move us forward. Since the patch was written, and it is a miniscule improvmeent, we can merge it to avoid holding back the series.