Attention is currently required from: Hoernchen, lynxis lazus, pespin.
Patch set 4:Code-Review +2
View Change
1 comment:
Patchset:
Patch Set #2:
This pointlessly churns code to muddy the blame without improving anything..
Nobody is blaming anyone for the way how the code it, at least not that I have seen/heard about it. I think the switch statement is a readability improvement - but it's of course what I'd call "sideways development" as it doesn't really appear to move us forward. Since the patch was written, and it is a miniscule improvmeent, we can merge it to avoid holding back the series.
To view, visit change 42171. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: Ic32fe16dff4b7bb933ec62e36a9c7c7829aece1b
Gerrit-Change-Number: 42171
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: Hoernchen <ewild@sysmocom.de>
Gerrit-Attention: Hoernchen <ewild@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis@fe80.eu>
Gerrit-Comment-Date: Wed, 25 Feb 2026 11:20:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de>