Attention is currently required from: neels, pespin, fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 )

Change subject: Add BTS setup ramping to prevent BSC overloading ......................................................................

Patch Set 6:

(4 comments)

Patchset:

PS6: Maybe somebody else should take care of this commit.

File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/3f44f1a6_46700c27 PS4, Line 2661: vty_out(vty, " bts-setup-ramp limit %d window %d%s",

This line needs updating.

Done

File src/osmo-bsc/bts_setup_ramp.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/32181d94_93e9d5e2 PS4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list);

maybe add a comment here that you are initializing the list so that it can be llist_deleted() later […]

exactly why we want to have a well defined value for empty llist_entries.

File src/osmo-bsc/nm_bts_sm_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/725e8d1f_e9485332 PS4, Line 102: static void configure_loop(struct gsm_bts_sm *site_mgr)

This is wrong. […]

Done