Attention is currently required from: neels, pespin, fixeria.

View Change

4 comments:

• Patchset:

  • Patch Set #6:

    Maybe somebody else should take care of this commit.

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #4, Line 2661: vty_out(vty, " bts-setup-ramp limit %d window %d%s",

    This line needs updating.

    Done

• File src/osmo-bsc/bts_setup_ramp.c:

  • Patch Set #4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list);

    maybe add a comment here that you are initializing the list so that it can be llist_deleted() later […]

    exactly why we want to have a well defined value for empty llist_entries.

• File src/osmo-bsc/nm_bts_sm_fsm.c:

  • Patch Set #4, Line 102: static void configure_loop(struct gsm_bts_sm *site_mgr)

    This is wrong. […]

    Done

To view, visit change 29788. To unsubscribe, or for help writing mail filters, visit settings.