Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email )
Change subject: bring twrtp into libosmo-netif ......................................................................
Patch Set 7:
(9 comments)
File include/osmocom/netif/twrtp.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/24aabbf7_88ec6864... : PS1, Line 26: struct osmo_twrtp_stats {
Please see how I handle it in Patchset 7.
Done
File src/twrtp.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/e32d73c2_19c0a0ed... : PS6, Line 231: endp->iofd_rtp = osmo_iofd_setup(endp, -1, NULL,
Please see how I handle it in Patchset 7.
Done
File src/twrtp.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/6e241ec1_b6a1b9ca... : PS7, Line 304: close(rtcp_fd); if (rtcp_fd >= 0) close(rtcp_fd);
https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/c2e0c004_3ba7c52e... : PS7, Line 313: close(rtcp_fd); if (rtcp_fd >= 0) close(rtcp_fd);
https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/15f382b7_7a580ece... : PS7, Line 322: close(rtcp_fd); if (rtcp_fd >= 0) close(rtcp_fd);
https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/5c828ce9_226dadff... : PS7, Line 333: close(rtcp_fd); if (rtcp_fd >= 0) close(rtcp_fd);
https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/a7083f49_61183593... : PS7, Line 343: close(rtcp_fd); if (rtcp_fd >= 0) close(rtcp_fd);
https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/3f71ef68_97e0184e... : PS7, Line 348: return 0; You could add return goto tags here for failing cases to make closing/freeing more organized and clean.
File src/twrtp_base.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/7201a664_e91a75dc... : PS1, Line 132: * another variant of this API with that alternative behavior.
Please see how I handle it in Patchset 7.
Done
-
pespin