Attention is currently required from: falconia.

View Change

9 comments:

• File include/osmocom/netif/twrtp.h:

  • Patch Set #1, Line 26: struct osmo_twrtp_stats {

    Please see how I handle it in Patchset 7.

    Done

• File src/twrtp.c:

  • Patch Set #6, Line 231: endp->iofd_rtp = osmo_iofd_setup(endp, -1, NULL,

    Please see how I handle it in Patchset 7.

    Done

• File src/twrtp.c:

  • Patch Set #7, Line 304: close(rtcp_fd);

    if (rtcp_fd >= 0)
        close(rtcp_fd);

  • Patch Set #7, Line 313: close(rtcp_fd);

    if (rtcp_fd >= 0)
        close(rtcp_fd);

  • Patch Set #7, Line 322: close(rtcp_fd);

    if (rtcp_fd >= 0)
        close(rtcp_fd);

  • Patch Set #7, Line 333: close(rtcp_fd);

    if (rtcp_fd >= 0)
        close(rtcp_fd);

  • Patch Set #7, Line 343: close(rtcp_fd);

    if (rtcp_fd >= 0)
        close(rtcp_fd);

  • Patch Set #7, Line 348: return 0;

    You could add return goto tags here for failing cases to make closing/freeing more organized and clean.

• File src/twrtp_base.c:

  • Patch Set #1, Line 132: * another variant of this API with that alternative behavior.

    Please see how I handle it in Patchset 7.

    Done

To view, visit change 39281. To unsubscribe, or for help writing mail filters, visit settings.