Attention is currently required from: pespin.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33525 )

Change subject: Re-store last LLC frames never completely acked when freeing DL TBF ......................................................................

Patch Set 2: Code-Review+1

(11 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/2006a7be_dd574a81 PS2, Line 9: Scenario: A DL TBF is assigned over PCH (CCCH) and we start transmitting DL data blocks blindly (would be easier to read with in gerrit with line breaks at 72 characters)

https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/41f7f316_468bb119 PS2, Line 15: where were

https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/53f49dd6_9a31e5fc PS2, Line 28: where were

https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/295765ae_a89f323f PS2, Line 29: og of

https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/0cff7b61_5ffb52a3 PS2, Line 30: improvement. Is there an issue about improving this in the future? (If so, reference it here?)

Patchset:

PS2: just some nitpicks about typos and comments, patch looks good otherwise!

File src/llc.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/b51d1ba0_b3526796 PS2, Line 368: OSMO_ASSERT(info); maybe add a comment on top of the function that the queue must not be empty if out_info is set?

File src/tbf_dl.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/f266a2f9_d0f26510 PS2, Line 86: lossing losing

File src/tbf_dl.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/f124de00_0d5ed293 PS2, Line 546: if any might be a bit nitpicky, but the "if any" part is dealt with above; now the function will assert if at this point the queue is empty. maybe remove that part of the comment?

https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/3f6faa02_2ba3b0ce PS2, Line 667: lossing losing

https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/b63b24a6_6259ea4c PS2, Line 1152: trasnmission transmission