Attention is currently required from: pespin.
Patch set 2:Code-Review +1
11 comments:
Commit Message:
Patch Set #2, Line 9: Scenario: A DL TBF is assigned over PCH (CCCH) and we start transmitting DL data blocks blindly
(would be easier to read with in gerrit with line breaks at 72 characters)
Patch Set #2, Line 15: where
were
Patch Set #2, Line 28: where
were
of
Patch Set #2, Line 30: improvement.
Is there an issue about improving this in the future? (If so, reference it here?)
Patchset:
just some nitpicks about typos and comments, patch looks good otherwise!
File src/llc.c:
Patch Set #2, Line 368: OSMO_ASSERT(info);
maybe add a comment on top of the function that the queue must not be empty if out_info is set?
File src/tbf_dl.h:
Patch Set #2, Line 86: lossing
losing
File src/tbf_dl.cpp:
Patch Set #2, Line 546: if any
might be a bit nitpicky, but the "if any" part is dealt with above; now the function will assert if at this point the queue is empty. maybe remove that part of the comment?
Patch Set #2, Line 667: lossing
losing
Patch Set #2, Line 1152: trasnmission
transmission
To view, visit change 33525. To unsubscribe, or for help writing mail filters, visit settings.