Attention is currently required from: fixeria.

falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/38311?usp=email )

Change subject: silent-call: add CSD channel modes ......................................................................

Patch Set 1:

(1 comment)

File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/c/osmo-msc/+/38311/comment/a7465c18_c5be4af7?usp=... : PS1, Line 1596: ct.ch_rate_type = sign ? GSM0808_SPEECH_FULL_PREF : GSM0808_SIGN_ANY; It looks like you forgot to reverse the order of `GSM0808_SPEECH_FULL_PREF` and `GSM0808_SIGN_ANY` when inverting the sense from `speech` to `sign`.