Attention is currently required from: fixeria, laforge, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38292?usp=email ) Change subject: libosmotrau: implement RAA' encoder function ...................................................................... Patch Set 4: (1 comment) File include/Makefile.am: https://gerrit.osmocom.org/c/libosmo-abis/+/38292/comment/eb25dfce_291faebc?... : PS4, Line 8: raa_prime

Maybe prefix header name with `csd_` for consistency with `csd_ra2.h`, i.e. […] Before I spin yet another patch revision and invalidate everyone's votes, let's ask the other reviewers how they feel about header file naming: should it remain `raa_prime.h`, or should it be renamed to `csd_raa_prime.h`?

How did this inconsistency come about in the first place? I originally had just the two patches for RAA-prime, but then I saw myself replicating RA2 code in the third place (after Vadim's original implementation in OsmoBTS and my first replication in below-14.4 trau_rtp_conv functions), hence I decided to create `csd_ra2` layer as a prepatch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38292?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I11fc1529f5be88fa778c7e05cb11eef58a389d40 Gerrit-Change-Number: 38292 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sat, 28 Sep 2024 14:27:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>