Attention is currently required from: fixeria, laforge, pespin.

View Change

1 comment:

• File include/Makefile.am:

  • Patch Set #4, Line 8: raa_prime

    Maybe prefix header name with `csd_` for consistency with `csd_ra2.h`, i.e. […]

    Before I spin yet another patch revision and invalidate everyone's votes, let's ask the other reviewers how they feel about header file naming: should it remain `raa_prime.h`, or should it be renamed to `csd_raa_prime.h`?

    How did this inconsistency come about in the first place? I originally had just the two patches for RAA-prime, but then I saw myself replicating RA2 code in the third place (after Vadim's original implementation in OsmoBTS and my first replication in below-14.4 trau_rtp_conv functions), hence I decided to create `csd_ra2` layer as a prepatch.

To view, visit change 38292. To unsubscribe, or for help writing mail filters, visit settings.