[S] Change in libosmocore[master]: gmstap_log: optimization: Add talloc_pool for transmitted messages - gerrit-log

16 Jan 2026


      Attention is currently required from: daniel, laforge, osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email )
Change subject: gmstap_log: optimization: Add talloc_pool for transmitted messages
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/core/logging_gsmtap.c:
https://gerrit.osmocom.org/c/libosmocore/+/41865/comment/d67f05d7_0b05e888?u... :
PS4, Line 77: msgb_alloc_c
Maybe keep using `tall_msgb_ctx` for embedded builds?
```suggestion
#ifndef EMBEDDED
    msg = msgb_alloc_c((void *)target->output, GSMTAP_MSG_MAX_SIZE, "GSMTAP logging");
#else
    /* keep using tall_msgb_ctx */
    msg = msgb_alloc(GSMTAP_MSG_MAX_SIZE, "GSMTAP logging");
#endif
```
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41865?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I19cdf09f21d856e8e3646de495ce7ae040195268
Gerrit-Change-Number: 41865
Gerrit-PatchSet: 4
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Fri, 16 Jan 2026 21:16:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes