Attention is currently required from: daniel, laforge, osmith, pespin.

Patch set 4:Code-Review +1

View Change

1 comment:

• File src/core/logging_gsmtap.c:

  • Patch Set #4, Line 77: msgb_alloc_c

    Maybe keep using `tall_msgb_ctx` for embedded builds?

    ```suggestion
    #ifndef EMBEDDED
    	msg = msgb_alloc_c((void *)target->output, GSMTAP_MSG_MAX_SIZE, "GSMTAP logging");
    #else
    	/* keep using tall_msgb_ctx */
    	msg = msgb_alloc(GSMTAP_MSG_MAX_SIZE, "GSMTAP logging");
    #endif
    ```

To view, visit change 41865. To unsubscribe, or for help writing mail filters, visit settings.