Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36149?usp=email ) Change subject: stp: prepare for testing M3UA-over-TCP ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36149/comment/e71d6125_c57b… PS1, Line 285: if (not Misc_Helpers.f_osmo_repo_is("nightly")) { There is no benefit. It's needed because doing this unconditionally would make **all** testcases fail for the -latest osmo-stp, because it does not support M3UA-over-TCP. Just like any other IUT version specific quirks, right? Nothing new here. No, we don't want to let all testcases fail for the -latest. Just to make it clear, this testsuite is written in a way that for each testcase we establish connections with all ASPs configured in `mp_m3ua_configs[]` (even if a testcase talks to one or two of them). In this patch I am adding new ASPs using TCP, so here I simply skip those for `!= "nightly"` and ensure that the existing testcases are still passing for the -latest. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5d0b05aa434c057ad379125ac293f5fc9a240b6f Gerrit-Change-Number: 36149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 16:15:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment