Attention is currently required from: laforge, pespin.

View Change

1 comment:

• File stp/STP_Tests_M3UA.ttcn:

  • Patch Set #1, Line 285: if (not Misc_Helpers.f_osmo_repo_is("nightly")) {

    I don't see why do we want to add this code here, what's the benefit?

    There is no benefit. It's needed because doing this unconditionally would make **all** testcases fail for the -latest osmo-stp, because it does not support M3UA-over-TCP.

    we then need to maintain and remove this at some point

    Just like any other IUT version specific quirks, right? Nothing new here.

    Just let it fail below if running against some other version.

    No, we don't want to let all testcases fail for the -latest.

    Just to make it clear, this testsuite is written in a way that for each testcase we establish connections with all ASPs configured in `mp_m3ua_configs[]` (even if a testcase talks to one or two of them). In this patch I am adding new ASPs using TCP, so here I simply skip those for `!= "nightly"` and ensure that the existing testcases are still passing for the -latest.

To view, visit change 36149. To unsubscribe, or for help writing mail filters, visit settings.