Attention is currently required from: laforge, daniel, matanp.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32519 )

Change subject: ctrl: Add getting access control class ......................................................................

Patch Set 3:

(2 comments)

File src/osmo-bsc/bts_ctrl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/32519/comment/63e112ad_7090a49e PS3, Line 841: struct gsm_bts *bts = cmd->node; const

https://gerrit.osmocom.org/c/osmo-bsc/+/32519/comment/cc860341_e3734cd0 PS3, Line 859: for (i = 0; i < 8; i++) {

Is there a reason why you have two loops here, not just one?

Ah, I see now. The bitmask is spread over two octets. You could do something like:

``` uint16_t acc_mask;

acc_mask = bts->si_common.rach_control.t3; acc_mask |= bts->si_common.rach_control.t2 << 8; ```

But it's not critical and you can keep it as it is now.