Attention is currently required from: laforge, daniel, matanp.

View Change

2 comments:

• File src/osmo-bsc/bts_ctrl.c:

  • Patch Set #3, Line 841: struct gsm_bts *bts = cmd->node;

    const

  • Patch Set #3, Line 859: for (i = 0; i < 8; i++) {

    Is there a reason why you have two loops here, not just one?

    Ah, I see now. The bitmask is spread over two octets. You could do something like:

    ```
    uint16_t acc_mask;

    acc_mask = bts->si_common.rach_control.t3;
    acc_mask |= bts->si_common.rach_control.t2 << 8;
    ```

    But it's not critical and you can keep it as it is now.

To view, visit change 32519. To unsubscribe, or for help writing mail filters, visit settings.