Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27722 )

Change subject: osmo-bts-trx: rx_tchh_fn(): use a lookup table for FACCH/H ......................................................................

Patch Set 1:

(1 comment)

File src/osmo-bts-trx/sched_lchan_tchh.c:

https://gerrit.osmocom.org/c/osmo-bts/+/27722/comment/51ac4a16_9f609060 PS1, Line 85: int fn_is_odd = (((bi->fn + 26 - 10) % 26) >> 2) & 1;

Yes, this naming looks weird to me too. 'fn_is_facch' would have been a lot cleaner. […]

Then having a static inline function fn_is_facch which does "!sched_tchh_ul_facch_map[bi->fn % 26]" would be helpful to understand better the code imho. I'd welcome it at least.