Attention is currently required from: fixeria.

View Change

1 comment:

• File src/osmo-bts-trx/sched_lchan_tchh.c:

  • Patch Set #1, Line 85: int fn_is_odd = (((bi->fn + 26 - 10) % 26) >> 2) & 1;

    Yes, this naming looks weird to me too. 'fn_is_facch' would have been a lot cleaner. […]

    Then having a static inline function fn_is_facch which does "!sched_tchh_ul_facch_map[bi->fn % 26]" would be helpful to understand better the code imho. I'd welcome it at least.

To view, visit change 27722. To unsubscribe, or for help writing mail filters, visit settings.