Attention is currently required from: csaba.sipos, domi, fixeria, laforge.

pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )

Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ......................................................................

Patch Set 14:

(1 comment)

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/78c86bd3_185bcfd6?usp=... : PS14, Line 1716: #define FIND_ELEM(data, data_len, ei, var) (find_element(data, data_len, ei, var, sizeof(var)) == sizeof(var)) In here you'd be checking for "sizeof(&object_state)", which afaiu is wrong:

FIND_ELEM(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state)

You may need to write it above as "&var, sizeof(var)" but not sure if that's also going to work well for arrays. Otherwise you'll have to add one macro for a var pointer and another one for an array.