Attention is currently required from: csaba.sipos, domi, fixeria, laforge.

View Change

1 comment:

• File src/osmo-bsc/bts_nokia_site.c:

  • Patch Set #14, Line 1716: #define FIND_ELEM(data, data_len, ei, var) (find_element(data, data_len, ei, var, sizeof(var)) == sizeof(var))

    In here you'd be checking for "sizeof(&object_state)", which afaiu is wrong:

        FIND_ELEM(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state)

    You may need to write it above as "&var, sizeof(var)" but not sure if that's also going to work well for arrays.
    Otherwise you'll have to add one macro for a var pointer and another one for an array.

To view, visit change 39416. To unsubscribe, or for help writing mail filters, visit settings.