Attention is currently required from: laforge, lynxis lazus, pespin.

fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email )

Change subject: s2b: when socket opening fails, stop the S2b module ......................................................................

Patch Set 3:

(1 comment)

File src/epdg_gtpc_s2b.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901/comment/97b39dfd_e10b0... : PS3, Line 150: io_lib:format

Yes maybe true. I'm not sure what's the intended way of returning a reason is. […]

Well, the general approach is that formatted strings are for humans. You already let the humans know about an error via logging, so here you're letting the process' owner the failure `Reason`. The term `udp_socket_open_failed` is self-explanatory, so having a tuple `{udp_socket_open_failed, Reason}` would allow potential consumer of the `Reason` to format it any way they want (if at all).