Attention is currently required from: laforge, lynxis lazus, pespin.

View Change

1 comment:

• File src/epdg_gtpc_s2b.erl:

  • Patch Set #3, Line 150: io_lib:format

    Yes maybe true. I'm not sure what's the intended way of returning a reason is. […]

    Well, the general approach is that formatted strings are for humans. You already let the humans know about an error via logging, so here you're letting the process' owner the failure `Reason`. The term `udp_socket_open_failed` is self-explanatory, so having a tuple `{udp_socket_open_failed, Reason}` would allow potential consumer of the `Reason` to format it any way they want (if at all).

To view, visit change 37901. To unsubscribe, or for help writing mail filters, visit settings.