Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge, osmith.

Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )

Change subject: build: add --disable-multi-arfcn configure option ......................................................................

Patch Set 7:

(20 comments)

File Transceiver52M/radioInterfaceMulti.h:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/c957d88c_0508ce11?usp=... : PS7, Line 10: bool pushBuffer(); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/8366ccbf_94748e24?usp=... : PS7, Line 11: int pullBuffer(); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/9c1de04a_0edae98e?usp=... : PS7, Line 12: bool verify_arfcn_consistency(double freq, size_t chan, bool tx); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/c85a0eb5_ea84e868?usp=... : PS7, Line 13: virtual int setPowerAttenuation(int atten, size_t chan = 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/4c619f5b_87901454?usp=... : PS7, Line 15: signalVector *outerSendBuffer; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/4cdd5e6e_853a03e9?usp=... : PS7, Line 16: signalVector *outerRecvBuffer; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/be2d33c5_850f7f85?usp=... : PS7, Line 22: Resampler *dnsampler; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/54323422_d58fc469?usp=... : PS7, Line 23: Resampler *upsampler; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/8f46d566_3ab37897?usp=... : PS7, Line 24: Channelizer *channelizer; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/e167f5b7_d9f81dfe?usp=... : PS7, Line 25: Synthesis *synthesis; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/8e8bdae2_083a3a4f?usp=... : PS7, Line 28: RadioInterfaceMulti(RadioDevice* radio, size_t tx_sps, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/cd49dd74_4d31683f?usp=... : PS7, Line 29: size_t rx_sps, size_t chans = 1); code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/80fbffc2_2ed984ba?usp=... : PS7, Line 29: size_t rx_sps, size_t chans = 1); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/274f7378_ce00e783?usp=... : PS7, Line 30: virtual ~RadioInterfaceMulti(); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/8361883a_c8a11a74?usp=... : PS7, Line 32: bool init(int type); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/44c5304f_0a2e79b9?usp=... : PS7, Line 33: void close(); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/dc28232f_ea69c8a4?usp=... : PS7, Line 35: bool tuneTx(double freq, size_t chan); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/56ac9e52_c9173b31?usp=... : PS7, Line 36: bool tuneRx(double freq, size_t chan); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/a5284e89_5252db24?usp=... : PS7, Line 37: virtual double setRxGain(double dB, size_t chan); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/d7b5ad43_57e07fd3?usp=... : PS7, Line 38: virtual double rssiOffset(size_t chan = 0); please, no spaces at the start of a line