Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge, osmith.

View Change

20 comments:

• File Transceiver52M/radioInterfaceMulti.h:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 10: bool pushBuffer();

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 11: int pullBuffer();

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 12: bool verify_arfcn_consistency(double freq, size_t chan, bool tx);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 13: virtual int setPowerAttenuation(int atten, size_t chan = 0);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 15: signalVector *outerSendBuffer;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 16: signalVector *outerRecvBuffer;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 22: Resampler *dnsampler;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 23: Resampler *upsampler;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 24: Channelizer *channelizer;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 25: Synthesis *synthesis;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 28: RadioInterfaceMulti(RadioDevice* radio, size_t tx_sps,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 29: size_t rx_sps, size_t chans = 1);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 29: size_t rx_sps, size_t chans = 1);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 30: virtual ~RadioInterfaceMulti();

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 32: bool init(int type);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 33: void close();

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 35: bool tuneTx(double freq, size_t chan);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 36: bool tuneRx(double freq, size_t chan);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 37: virtual double setRxGain(double dB, size_t chan);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #7, Line 38: virtual double rssiOffset(size_t chan = 0);

    please, no spaces at the start of a line

To view, visit change 42243. To unsubscribe, or for help writing mail filters, visit settings.