Attention is currently required from: osmith, neels, dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33216 )

Change subject: osmo_sccp_simple_client_on_ss7_id(): Support ASP explicitly configured as sctp server ......................................................................

Patch Set 8:

(1 comment)

File src/sccp_user.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/33216/comment/1e1ea4c7_4dc825f1 PS8, Line 648: asp->cfg.is_server = false;

should we print a warning here? again not sure if asp->cfg. […]

"asp->cfg.is_server = true"is set by default in osmo_ss7_asp_find_or_create(). So here we want to set it to false by default *iif* it was not explicitly set over the VTY. It's not that important since I'm anwyay cleaning this complex logic in a followup patch (I did 2 patches because the next one is changing old behavior, while this one more like extends/fixes the old behavior).