Attention is currently required from: osmith, neels, dexter.
View Change
1 comment:
File src/sccp_user.c:
Patch Set #8, Line 648: asp->cfg.is_server = false;
should we print a warning here? again not sure if asp->cfg. […]
"asp->cfg.is_server = true"is set by default in osmo_ss7_asp_find_or_create().
So here we want to set it to false by default *iif* it was not explicitly set over the VTY.
It's not that important since I'm anwyay cleaning this complex logic in a followup patch (I did 2 patches because the next one is changing old behavior, while this one more like extends/fixes the old behavior).
To view, visit change 33216. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I20de33edb8751a515d6719c49efadfc387dd85f8
Gerrit-Change-Number: 33216
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jun 2023 11:53:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith@sysmocom.de>
Gerrit-MessageType: comment