Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email ) Change subject: bl updater app ...................................................................... Patch Set 4: (19 comments) File usb_dfu_main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8c50954c_94d4aa8… : PS4, Line 44: while (!NVMCTRL->STATUS.bit.READY) {} please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/be716502_7e5db9e… : PS4, Line 48: while (!NVMCTRL->STATUS.bit.READY) {} please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/99310423_6a5dbf3… : PS4, Line 51: volatile uint32_t *src = (uint32_t *)data; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8cc916a7_bfddaf1… : PS4, Line 53: for (uint32_t i = 0; i < (NVMCTRL_PAGE_SIZE / sizeof(uint32_t)); i++) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/737d5a27_2684ee4… : PS4, Line 54: dst[i] = src[i]; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3c057103_de0b923… : PS4, Line 55: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/20a37da3_32e1408… : PS4, Line 57: NVMCTRL->ADDR.reg = address; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/1eba64e8_ae53be3… : PS4, Line 58: NVMCTRL->CTRLB.reg = NVMCTRL_CTRLB_CMD_WP | NVMCTRL_CTRLB_CMDEX_KEY; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8919cae6_8bfb350… : PS4, Line 59: while (!NVMCTRL->INTFLAG.bit.DONE) {} please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/514f261a_21b9619… : PS4, Line 60: while (!NVMCTRL->STATUS.bit.READY) {} please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/accef3a9_4191981… : PS4, Line 105: uint32_t address = 0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/7a054b03_2a6ae9d… : PS4, Line 106: uint8_t *data_ptr = (uint8_t *)bl_update_data; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/50b965da_a7bc60b… : PS4, Line 107: uint32_t remaining = BLSZ_BYTE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5e4dd0d8_b67b008… : PS4, Line 109: while (remaining >= NVMCTRL_PAGE_SIZE) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5a1c6c29_ee02f25… : PS4, Line 110: same54_flash_write_page(address, data_ptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f1e542cd_fa439af… : PS4, Line 111: address += NVMCTRL_PAGE_SIZE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b0fdc5c0_fb55d9a… : PS4, Line 112: data_ptr += NVMCTRL_PAGE_SIZE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3a7a1b66_fae988a… : PS4, Line 113: remaining -= NVMCTRL_PAGE_SIZE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ebc8d373_c93a315… : PS4, Line 114: } please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1403d35497cdea41ea5bed2c94b9e729ca352772 Gerrit-Change-Number: 39434 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Comment-Date: Wed, 29 Jan 2025 19:10:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No