Attention is currently required from: Hoernchen.

View Change

19 comments:

• File usb_dfu_main.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 44: while (!NVMCTRL->STATUS.bit.READY) {}

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 48: while (!NVMCTRL->STATUS.bit.READY) {}

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 51: volatile uint32_t *src = (uint32_t *)data;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 53: for (uint32_t i = 0; i < (NVMCTRL_PAGE_SIZE / sizeof(uint32_t)); i++) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 54: dst[i] = src[i];

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 55: }

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 57: NVMCTRL->ADDR.reg = address;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 58: NVMCTRL->CTRLB.reg = NVMCTRL_CTRLB_CMD_WP | NVMCTRL_CTRLB_CMDEX_KEY;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 59: while (!NVMCTRL->INTFLAG.bit.DONE) {}

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 60: while (!NVMCTRL->STATUS.bit.READY) {}

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 105: uint32_t address = 0;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 106: uint8_t *data_ptr = (uint8_t *)bl_update_data;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 107: uint32_t remaining = BLSZ_BYTE;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 109: while (remaining >= NVMCTRL_PAGE_SIZE) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 110: same54_flash_write_page(address, data_ptr);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 111: address += NVMCTRL_PAGE_SIZE;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 112: data_ptr += NVMCTRL_PAGE_SIZE;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 113: remaining -= NVMCTRL_PAGE_SIZE;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273):

    Patch Set #4, Line 114: }

    please, no spaces at the start of a line

To view, visit change 39434. To unsubscribe, or for help writing mail filters, visit settings.