Attention is currently required from: pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34470?usp=email )

Change subject: abis_nm: handle NM_EV_SW_ACT_REP in ST_OP_DISABLED_{DEPENDENCY,OFFLINE} ......................................................................

Patch Set 1:

(3 comments)

File src/osmo-bsc/nm_bts_sm_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/e3da0ddb_eebdf5e3 PS1, Line 123: case NM_EV_SW_ACT_REP:

why is configure_loop() not called here?

Because no other events in this function call it, e.g. `NM_EV_SETUP_RAMP_READY` does not. Do you think it should be called here? And also in the case of `NM_EV_SETUP_RAMP_READY`? I can update the patch.

File src/osmo-bsc/nm_gprs_nsvc_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/3a85e2d5_7cdee485 PS1, Line 179: case NM_EV_SW_ACT_REP:

missing configure_loop?

It's not missing. What's missing is the `break`, so we fall-through.

https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/4ebea1f4_6b290d7d PS1, Line 233: case NM_EV_SW_ACT_REP:

missing configure_loop?

It's not missing. What's missing is the `break`, so we fall-through.