Attention is currently required from: pespin.

View Change

3 comments:

• File src/osmo-bsc/nm_bts_sm_fsm.c:

  • Patch Set #1, Line 123: case NM_EV_SW_ACT_REP:

    why is configure_loop() not called here?

    Because no other events in this function call it, e.g. `NM_EV_SETUP_RAMP_READY` does not. Do you think it should be called here? And also in the case of `NM_EV_SETUP_RAMP_READY`? I can update the patch.

• File src/osmo-bsc/nm_gprs_nsvc_fsm.c:

  • Patch Set #1, Line 179: case NM_EV_SW_ACT_REP:

    missing configure_loop?

    It's not missing. What's missing is the `break`, so we fall-through.

  • Patch Set #1, Line 233: case NM_EV_SW_ACT_REP:

    missing configure_loop?

    It's not missing. What's missing is the `break`, so we fall-through.

To view, visit change 34470. To unsubscribe, or for help writing mail filters, visit settings.