Attention is currently required from: neels, pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 )

Change subject: SS7: do not attempt transfer if AS is down ......................................................................

Patch Set 2: Code-Review+2

(2 comments)

File src/osmo_ss7.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/31295/comment/4b4ad1c2_72a8040e PS2, Line 1151: if (!as->fi)

So now we enter the debate whether an unexisting as is down or not. […]

Ack

File src/osmo_ss7_hmrt.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/31295/comment/5eaa6c76_5aa329c0 PS2, Line 234: return -ENETDOWN;

I'm fine with ENETDOWN, to me that's what's being cecked.

neels point-of-view is from the IP/socket perspective, while pespin is looking at it from the SS7 perspective. I also think NETDOWN is fine. From the SS7 point of view, the SCTP assocation is the underlying physical medium.