Attention is currently required from: neels, pespin, msuraev.

Patch set 2:Code-Review +2

View Change

2 comments:

• File src/osmo_ss7.c:

  • Patch Set #2, Line 1151: if (!as->fi)

    So now we enter the debate whether an unexisting as is down or not. […]

    Ack

• File src/osmo_ss7_hmrt.c:

  • Patch Set #2, Line 234: return -ENETDOWN;

    I'm fine with ENETDOWN, to me that's what's being cecked.

    neels point-of-view is from the IP/socket perspective, while pespin is looking at it from the SS7 perspective. I also think NETDOWN is fine. From the SS7 point of view, the SCTP assocation is the underlying physical medium.

To view, visit change 31295. To unsubscribe, or for help writing mail filters, visit settings.