Attention is currently required from: fixeria, laforge, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38457?usp=email )
Change subject: ggsn: Support announcing APN MTU over PCO ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
File ggsn/ggsn.h:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457/comment/918dde21_7d6b5cf8?usp... : PS4, Line 36: #define IPV6_HDR_MAX_SIZE 40 /* Assume no extension headers in general... */
Yes because we assume no extension headers used by ipv6, while we account for maximum number of exte […]
Acknowledged
File ggsn/ggsn_vty.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457/comment/c6f120a1_87498701?usp... : PS4, Line 425: "mtu (<0-1464>|default)",
It cannot be done, I already tried once. […]
Acknowledged
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457/comment/bbaf2c97_1cc06fa9?usp... : PS4, Line 428: "Default value of the MTU of the APN (1420)")
It cannot be done, I already tried once. […]
Acknowledged
https://gerrit.osmocom.org/c/osmo-ggsn/+/38457/comment/075fc300_e606542c?usp... : PS4, Line 708: vty_out(vty, " mtu %" PRIu16 "%s", apn->cfg.mtu, VTY_NEWLINE);
I'd rather keep it like this, I think it's actually a good idea to always print it, the default is n […]
Acknowledged
-
osmith