Attention is currently required from: fixeria, laforge, pespin.

Patch set 4:Code-Review +1

View Change

4 comments:

• File ggsn/ggsn.h:

  • Patch Set #4, Line 36: #define IPV6_HDR_MAX_SIZE 40 /* Assume no extension headers in general... */

    Yes because we assume no extension headers used by ipv6, while we account for maximum number of exte […]

    Acknowledged

• File ggsn/ggsn_vty.c:

  • Patch Set #4, Line 425: "mtu (<0-1464>|default)",

    It cannot be done, I already tried once. […]

    Acknowledged

  • Patch Set #4, Line 428: "Default value of the MTU of the APN (1420)")

    It cannot be done, I already tried once. […]

    Acknowledged

  • Patch Set #4, Line 708: vty_out(vty, " mtu %" PRIu16 "%s", apn->cfg.mtu, VTY_NEWLINE);

    I'd rather keep it like this, I think it's actually a good idea to always print it, the default is n […]

    Acknowledged

To view, visit change 38457. To unsubscribe, or for help writing mail filters, visit settings.