Attention is currently required from: fixeria, pespin, dexter. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33297 ) Change subject: ASCI: Add Notification CHannel (NCH) support ...................................................................... Patch Set 7: (1 comment) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/33297/comment/c377ddd0_50812d2f PS6, Line 726: int is_nch_res, int is_ag_res If is_nch_res is set, the message to be sent is an NCH message on NCH. If not, is_ag_res indicates if the channel is PCH or AGCH. If there is no paging, PCH can be used as AGCH, if there is an AGCH message in the queue. In case of is_nch_res beeing, the function must return after getting the message with nch_gen_msg(). I fixed that. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I82fdaba3faaced76267a99ae14a5458a1b41fdaa Gerrit-Change-Number: 33297 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 12:59:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment