Attention is currently required from: fixeria, pespin, dexter.
View Change
1 comment:
File src/common/bts.c:
Patch Set #6, Line 726: int is_nch_res, int is_ag_res
Do we expect/permit any combinations of these two flags? […]
If is_nch_res is set, the message to be sent is an NCH message on NCH. If not, is_ag_res indicates if the channel is PCH or AGCH. If there is no paging, PCH can be used as AGCH, if there is an AGCH message in the queue.
In case of is_nch_res beeing, the function must return after getting the message with nch_gen_msg(). I fixed that.
To view, visit change 33297. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I82fdaba3faaced76267a99ae14a5458a1b41fdaa
Gerrit-Change-Number: 33297
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Jul 2023 12:59:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment