Attention is currently required from: laforge, neels.
dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38014?usp=email )
Change subject: pySim.esim.saip: Implement optimized file content encoding ......................................................................
Patch Set 6:
(2 comments)
File pySim/esim/saip/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/38014/comment/8dc1dd68_93276169?usp=ema... : PS6, Line 61: assert match.a >= cur maybe return also return a ValueError? (The caller does not have to check for the ValueError and raise an exception? We return ValueErrors in other modules too, but I don't really get the concept)
https://gerrit.osmocom.org/c/pysim/+/38014/comment/a672edec_36f63d2d?usp=ema... : PS6, Line 463: ret.append(('fillFileOffset', block.a - cur)) cur is set to 0 at the beginning but it does not get re-assigned. Maybe there is something missing here?
-
dexter