Attention is currently required from: laforge, neels.

View Change

2 comments:

• File pySim/esim/saip/__init__.py:

  • Patch Set #6, Line 61: assert match.a >= cur

    maybe return also return a ValueError? (The caller does not have to check for the ValueError and raise an exception? We return ValueErrors in other modules too, but I don't really get the concept)

  • Patch Set #6, Line 463: ret.append(('fillFileOffset', block.a - cur))

    cur is set to 0 at the beginning but it does not get re-assigned. Maybe there is something missing here?

To view, visit change 38014. To unsubscribe, or for help writing mail filters, visit settings.